Skip to content

Conversation

@jf-leblancrichard
Copy link

No description provided.

@jf-leblancrichard jf-leblancrichard requested a review from a team as a code owner July 26, 2025 00:14
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 26, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.46%. Comparing base (9fea410) to head (1e2b1bc).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #411   +/-   ##
=========================================
  Coverage     81.46%   81.46%           
  Complexity     1667     1667           
=========================================
  Files           120      120           
  Lines          6953     6953           
=========================================
  Hits           5664     5664           
  Misses         1289     1289           
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Exporter/Instana 49.42% <ø> (ø)
Instrumentation/AwsSdk 81.13% <ø> (ø)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.55% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/Doctrine 92.92% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 75.58% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 69.68% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (ø)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (ø)
Instrumentation/Psr3 67.01% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.45% <ø> (ø)
Instrumentation/Slim 86.11% <ø> (ø)
Instrumentation/Symfony 84.88% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fea410...1e2b1bc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@intuibase
Copy link
Contributor

Hey
Just wanted to mention that I'm working on same instrumentation here:
https://github.com/intuibase/opentelemetry-php-contrib/blob/postgresql_instrumentation/src/Instrumentation/PostgreSql/src/PostgreSqlInstrumentation.php

I just have to implement unit tests.

@bobstrecansky
Copy link
Contributor

We believe this is a duplicate; closing. Please reopen if you have additional questions or concerns

@jf-leblancrichard
Copy link
Author

jf-leblancrichard commented Aug 6, 2025

Hi @intuibase,

Your PR seems much more feature complete than mine, so I think it makes sense to go with yours. I focused on only the subset of the pgsql methods we use.

Thanks for letting me know, and please let me know if I can be of any help!

@jf-leblancrichard
Copy link
Author

We believe this is a duplicate; closing. Please reopen if you have additional questions or concerns

@bobstrecansky Per the above, I'm fine closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants